Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

整理: Speaker に関するドキュメントを キャラクター ベースに変更 #1416

Merged
merged 19 commits into from
Jun 27, 2024

Conversation

tarepan
Copy link
Contributor

@tarepan tarepan commented Jun 21, 2024

内容

PR #1414 を細分化する方針に基づき、話者・歌手など Speaker に関する用語をキャラクターベースに変更するリファクタリングを提案します。
本 PR は #1414 のうちドキュメントにあたる部分です。

関連 Issue

part of #1414
ref #1262

@tarepan tarepan requested a review from a team as a code owner June 21, 2024 15:52
@tarepan tarepan requested review from Hiroshiba and removed request for a team June 21, 2024 15:52
@tarepan tarepan marked this pull request as draft June 21, 2024 15:53
@tarepan tarepan changed the title 整理: Speaker と Character をドキュメント 整理: Speaker に関するドキュメントを キャラクター ベースに変更 Jun 21, 2024
@tarepan tarepan marked this pull request as ready for review June 25, 2024 19:35
@tarepan
Copy link
Contributor Author

tarepan commented Jun 25, 2024

先行 PRs が merge されました。
レビューよろしくお願いします。

Copy link
Member

@Hiroshiba Hiroshiba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ほぼLGTMです!!

README.md Outdated Show resolved Hide resolved
test/benchmark/speed/speaker.py Outdated Show resolved Hide resolved
test/e2e/test_characters.py Outdated Show resolved Hide resolved
voicevox_engine/app/routers/character.py Outdated Show resolved Hide resolved
voicevox_engine/metas/Metas.py Show resolved Hide resolved
@Hiroshiba Hiroshiba self-requested a review June 26, 2024 03:43
tarepan and others added 2 commits June 26, 2024 13:38
Co-authored-by: Hiroshiba <[email protected]>
@tarepan
Copy link
Contributor Author

tarepan commented Jun 26, 2024

@Hiroshiba
全指摘箇所の反映・テストパスを確認しました。Re-review よろしくお願いします。

Co-authored-by: Hiroshiba <[email protected]>
@tarepan
Copy link
Contributor Author

tarepan commented Jun 26, 2024

@Hiroshiba
全指摘箇所の反映・テストパスを確認しました。Re2-review よろしくお願いします。

Copy link
Member

@Hiroshiba Hiroshiba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!!

これは覚えてたらバージョンアップのときにrelease noteに書きたいですね!

@Hiroshiba Hiroshiba merged commit 3a666dd into VOICEVOX:master Jun 27, 2024
4 checks passed
@tarepan tarepan deleted the refactor/character_docs branch June 27, 2024 03:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants