-
Notifications
You must be signed in to change notification settings - Fork 204
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
整理: Speaker に関するドキュメントを キャラクター
ベースに変更
#1416
Conversation
キャラクター
ベースに変更
先行 PRs が merge されました。 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ほぼLGTMです!!
Co-authored-by: Hiroshiba <[email protected]>
@Hiroshiba |
Co-authored-by: Hiroshiba <[email protected]>
@Hiroshiba |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!!
これは覚えてたらバージョンアップのときにrelease noteに書きたいですね!
内容
PR #1414 を細分化する方針に基づき、話者・歌手など Speaker に関する用語をキャラクターベースに変更するリファクタリングを提案します。
本 PR は #1414 のうちドキュメントにあたる部分です。
関連 Issue
part of #1414
ref #1262